POC comments alongside RRTs #2852
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows saving contextual information, dates etc... in order to better contextualize RRT entries
Contributor
Author
|
We ended up playing down the customer requirements. I end up not needing this in James for now, though the idea is indeed interesting and could be revived in the future. (Feedback welcome: if this makes sense I'd be happy to polish this POC and get it inside James) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short
A customer allows regular user to use forwards.
Customer want to disable user: in which case they want t force a forward in addition to the forward already defined.
When enabling back the user they want to remove only the forwards they set and not those positionned by the user.
Indeed they wish not to maintain a state.
Proposed solution
As mapping is mostly an unstructured field we can easily add a comment into it.
This allows storing a comment which allows to distnguish automatically added forwrds from the others.
(I can also see functonnal application for this)
Alternatives
New mapping type: not realistic, generalization of RRT seems like a needlessly hard problem.