Fix map size in CustomAnalyzer#paramsToMap.

[vsop-479]

Description

[github-actions]

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

[uschindler]

Looks fine, I think this was an oversight.

Anyways we should remove and deprecated CollectionUtil, see comment here:

lucene/lucene/core/src/java/org/apache/lucene/util/CollectionUtil.java

Lines 41 to 44 in a55be5c

	public static <K, V> HashMap<K, V> newHashMap(int size) {
	// This should be replaced with HashMap.newHashMap when lucene moves to jdk19 minimum version
	return new HashMap<>((int) (size / 0.75f) + 1);
	}

We're on Java 19 since long time! :-) So both Lucene 10 and Main can use the JDK provided method. Let's open a PR!

[uschindler]

Let's backport this to 10.x

[vsop-479]

We're on Java 19 since long time! :-) So both Lucene 10 and Main can use the JDK provided method. Let's open a PR!

OK, I will do it.

[uschindler]

Hi,
I think we should add an extra buffer of 1 entries to the has map, because the code later adds 1 extra default entries to the map, so it will be resized.

https://github.com/vsop-479/lucene-fork/blob/f0be57db06f3ba821dd12815c8a55e3ea2757888/lucene/analysis/common/src/java/org/apache/lucene/analysis/custom/CustomAnalyzer.java#L596

[vsop-479]

I think we should add an extra buffer of 1 entries to the has map, because the code later adds 1 extra default entries to the map, so it will be resized.

OK, I will fix it.

[vsop-479]

I think we should add an extra buffer of 1 entries to the has map, because the code later adds 1 extra default entries to the map, so it will be resized.

Added with #15517.