Ensure that FilterXxx properly delegate to the decorated instances #15469
+852
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
The patch introduce a new assertion method in LuceneTestCase that verify that a given base decorator class (Filter) properly delegate all methods calls to the wrapped instance. The patch add the missing delegation methods. Closes apache#15452
dweiss
reviewed
Jan 8, 2026
Contributor
dweiss
left a comment
dweiss
left a comment
There was a problem hiding this comment.
I like it very much. Especially the tests that get simplified. I've noticed a few things that seem odd to me but I'll need to understand what's going on better. Please give me some time to dive deeper into it. Looks great though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial version of the patch as I am waiting for the result of the discussion on the mailing list.
The patch introduce a new assertion method in LuceneTestCase that verify that a given Decorator class (FilterXxx) properly delegate all methods calls to the wrapped instance. The patch add the missing delegation methods.
Closes #15452
Description