Refactor DocValuesSkipper stat methods to accept IndexReader instead of IndexSearcher #15514
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
approved these changes
Dec 22, 2025
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. Made a minor javadoc suggestion.
| * available | ||
| * | ||
| * @param searcher a searcher over the index | ||
| * @param reader the index reader to be stated |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param reader the index reader to be stated | |
| * @param reader the index reader to be queried |
| * available | ||
| * | ||
| * @param searcher a searcher over the index | ||
| * @param reader the index reader to be stated |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param reader the index reader to be stated | |
| * @param reader the index reader to be queried |
| * Returns the total skipper document count for a field across all segments | ||
| * | ||
| * @param searcher a searcher over the index | ||
| * @param reader the index reader to be stated |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param reader the index reader to be stated | |
| * @param reader the index reader to be queried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #15083 (comment)