Skip to content

DIRMINA-1199 - race condition when sending multiple larger data chunks #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
the-thing merged 5 commits into from
Oct 9, 2026
Merged

DIRMINA-1199 - race condition when sending multiple larger data chunks #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a670604
SSL race condition when sending multiple larger data chunks
the-thing Oct 7, 2026
4772688
Post review fixes
the-thing Oct 9, 2026
ef36f0b
Post review fixes #2
the-thing Oct 9, 2026
5ca2e25
Changing test parameters, increasing number of messages, adding more …
the-thing Oct 9, 2026
12a6d03
Add explicit useNonBlockingPipeline setting to SslFilter
the-thing Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mina-core/src/main/java/org/apache/mina/filter/ssl/SSLHandlerG1.java
View file
Open in desktop
Comment thread
the-thing marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -760,19 +760,19 @@ synchronized protected void store_pending_error(SSLException sslException) {
}

protected void forward_received(NextFilter next) {
//synchronized (mReceiveQueue) {
synchronized (mReceiveQueue) {
IoBuffer x;
while ((x = mReceiveQueue.poll()) != null) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("{} forward_received() - received {}", toString(), x);
}
next.messageReceived(mSession, x);
}
//}
}
}

protected void forward_writes(NextFilter next) {
//synchronized (mWriteQueue) {
synchronized (mWriteQueue) {
EncryptedWriteRequest x;
while ((x = mWriteQueue.poll()) != null) {
if (LOGGER.isDebugEnabled()) {
Expand All @@ -781,19 +781,19 @@ protected void forward_writes(NextFilter next) {
mAckQueue.add(x);
next.filterWrite(mSession, x);
}
//}
}
}

protected void forward_events(NextFilter next) {
//synchronized (mEventQueue) {
synchronized(mEventQueue) {
FilterEvent x;
while((x = mEventQueue.poll()) != null) {
while ((x = mEventQueue.poll()) != null) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("{} forward_events() - dispatching event {}", toString(), x);
}
next.event(mSession, x);
}
//}
}
}

/**
Expand Down
Loading
Loading