Repository navigation
Conversation
the-thing
changed the title
Member
Author
|
Updated title. It is not actually a fix for DIRMINA-1140, but the test that is flaky itself. |
the-thing
changed the title
NioDatagramAcceptorTest - static ExceptionMonitor filtering
the-thing
changed the title
NioDatagramAcceptorTest - static ExceptionMonitor filteringNioDatagramAcceptorTest - static ExceptionMonitor filtering
the-thing
marked this pull request as draft
October 10, 2026 06:34
the-thing
marked this pull request as ready for review
October 10, 2026 07:04
the-thing
force-pushed
the
filtering-interrupted-exception
branch
from
October 10, 2026 07:39
ea0958b to
5bb8e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fixed DIRMINA-1140 in #75 but it still fails from time to time e.g https://github.com/apache/mina/actions/runs/37960280693/job/113921075126
The problem is that the
org.apache.mina.transport.socket.nio.NioDatagramAcceptorTestassertion relies on exception capture viaorg.apache.mina.util.ExceptionMonitorwhich is static and accessed from many classes.Changes
I added filtering to only count failures when exceptions are throw from
org.apache.mina.transport.socket.nio.NioDatagramAcceptordirectly which was the original issue.Alternative
One of the alternative fixes is to provide an instance exception monitor field to
NioDatagramAcceptorthat is only visible to the test.