Add HTML rule and hint+fix for missing alt attribute for tag img, applet and area #4485

Chris2011 · 2022-08-08T19:53:31Z

This PR adds a new HTML Rule, Hint and HintFix for a missing "alt" attribute for following tags: img, applet, area.

I copied over some code from existing ExtractInlinedStyleRule and ExtractInlinedStyleHint and checked it, how it works. Fun fact, atm ExtractInlinedStyleHintFix is not working atm, it will throw an NPE, but this is not broken due to my changes. I will try to fix this later, in a seperate PR. Please have a look into the code. I will handle this as a draft and I will change some things like to add the rule/hint to the layers.xml instead of the HtmlHintsProvider as mentioned in the comment.

Also I changed a private method which gives you the exact offset of the tag <tag></tag> or <img /> problem here is that I need to add the attribute before the closing token and the adjustOffset gave me the offset after the closing tag so I added a bool to change this behaviour just for my and future needs. The rest is still working as before.

I also wanted try to add tests for the hint, but there are atm no tests at all.

I also notied the extra space before my " alt=""" when it is a closing tag. I can also try to fix this to check for token WS but it is the same behaviour as for WebStorm. It is better than nothing IMHO.

Chris2011 · 2022-08-08T19:56:05Z

I also thought to not hardcode the supported tags, but to use the validator rule for this, but this was to much for me. If this is wanted I can try to add this too, so this will be a bit more generic if other HTML tags are coming with the same validator rule.

...beans/modules/html/editor/hints/other/AddMissingAltAttribute/AddMissingAltAttributeHint.java

Chris2011 · 2022-08-09T20:16:41Z

Now I removed the rule and hint from the HintsProvider and add it to the layer.xml. The new rule extends now HtmlRule and runs the Hint by itself.

Chris2011 · 2022-08-10T07:03:45Z

Do I need to worry about the failing travis stuff? A quick look seems not related to my stuff anyway.

mbien · 2022-08-10T11:36:11Z

Do I need to worry about the failing travis stuff? A quick look seems not related to my stuff anyway.

I just restarted them. Looks good so far. You don't have a restart button?

matthiasblaesing

I left a few inline comments, but I made a general observation, that the integration looks a bit strange right now:

As you can see, I get an error indicator for the img-Tag, but I don't get the fixes. To get these I have to click inside the range of img-Tag:

I think this should be made consistent.

ide/html.editor/src/org/netbeans/modules/html/editor/hints/HtmlHintsProvider.java

matthiasblaesing · 2022-08-10T18:46:54Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+
+        if (project == null) {
+            return false;
+        }


Why is the project checked - it is not used later. This results in this:

The cursor is in the img-Tag (see my general comment), I get the error indicator, but I don't get the fix.

Thx for the hint, yeah I didn't test an HTML file w/o having a project :).

matthiasblaesing · 2022-08-10T18:47:06Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+
+        if (file == null) {
+            return false;
+        }


Why is the file checked - it is not used.

Chris2011 · 2022-08-11T07:08:39Z

Do I need to worry about the failing travis stuff? A quick look seems not related to my stuff anyway.

I just restarted them. Looks good so far. You don't have a restart button?

I had, but I didn't want to create some noice. But next time, I will try this first :). Thx for the info.

Chris2011 · 2022-08-13T15:20:34Z

I left a few inline comments, but I made a general observation, that the integration looks a bit strange right now:

As you can see, I get an error indicator for the img-Tag, but I don't get the fixes. To get these I have to click inside the range of img-Tag:

I think this should be made consistent.

Thx @matthiasblaesing you are right and I already tried a bit but the offset and searching logic for tokens (Tag open, tag open symbol, tag closing, etc.) drives me crazy. Will try to fix this.

Chris2011 · 2022-12-06T20:44:40Z

@matthiasblaesing after long thinking about this again I would disagree with the consistency. The warning/error/hint is really just for the tag img. In my little example you can see that the img tag is highlighted when a div is surrounded. So the hint shows it exactly for line + columnStart until columnEnd. For example if you have this example:

<div><img src="" /></div>

I really don't want to have the fix inside the div which is correct on this position. So the fix should be really inside of the img tag not anywhere else.

Maybe the problem here is that the hint on the sidebar has an other expectation for the user.

Here are some other things:

I checked the HTML validator it also selects the img tag, I mean you have all the information from that.
I checked VS Code. They have no light bulb hardcoded on the sidebar so they just underline the img tag. The light bulb comes up when I set the cursor after <|.
I checked WebStorm, it treats the missing alt attribute also as warning, but they don't show the warning as a light bulb and I also can't switch this. The light bulb also appears just after I set the cursor on <|.

So all in all, I think how NetBeans treats and shows warnings, is not optimal but this is not what I want to fix here. I also changed from warning to suggestion on current line, but the problem here is the highlight disappears too and the "suggestion" is just seen in the statusbar BUT it just appears also on the img, not on the whitespace tokens before the tag_open_symbol. Hope that explains a bit more. I will just fix also a multi line img which makes sense to have the fix there too but not for the whole line. This will be a hole new topic IMHO.

matthiasblaesing · 2022-12-18T12:01:20Z

@Chris2011 something went wrong here. There is a massive set of changes where and you have conflict with master. This needs to be redone.

Chris2011 · 2022-12-18T13:14:17Z

@matthiasblaesing thx for the info, will have a look soon.

Chris2011 · 2022-12-18T22:29:43Z

@matthiasblaesing I think I got it now :). I did the pull and rebase from within NetBeans and it had some conflicts, that I thought I fixed them but unfortunately not correct, sry for that. I reset everything to my last commit.

So now we can focus again on the initial task and my thoughts to it.

matthiasblaesing

I made a second pass over the changes. Please recheck the inline comments.

matthiasblaesing · 2022-12-19T20:30:52Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+
+/**
+ *
+ * @author Chris


I suggest to either replace this with something more distinctive (there are multiple instances of Chris) or remove it (history holds the full author information).

matthiasblaesing · 2022-12-19T20:32:01Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+            }
+
+            //the joined ts is moved to the from offset and a token already selected (moveNext/Previous() == true)
+            //seek for all tag's attributes with css embedding representing an inlined style


this comment looks as if it does not match.

matthiasblaesing · 2022-12-19T20:40:18Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+            }
+
+            //the joined ts is moved to the from offset and a token already selected (moveNext/Previous() == true)
+            //seek for all tag's attributes with css embedding representing an inlined style


This looks to complex to find the alt Attribute. The variables here indicate extraction of class, alt, id - is this copied from somewhere else?

Yes, also as you can see the comments, it was copied from the method findInlineStyle of class ExtractInlinedStyleRule. I started to copy stuff around, test some stuff and didn't fix code that much what was already there. Sry for that. I just wanted to get it working first. I will try to find anouther solution maybe with that what I already used for the HtmlCompletionProvider LexerUtils.followsToken(....

matthiasblaesing · 2022-12-19T20:45:04Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+ *
+ * @author Chris
+ */
+@NbBundle.Messages("AddMissingAltAttributeRuleName=Insert required 'alt' attribute")


This message key should be AddMissingAltAttributeRule - you can then drop the implementation of getDisplayName as the superclass already implements it:

netbeans/ide/html.editor/src/org/netbeans/modules/html/editor/hints/HtmlRule.java

Lines 86 to 89 in a8edf3b

@Override

public String getDisplayName() {

return NbBundle.getMessage(HtmlRule.class, getId());

}

with

netbeans/ide/html.editor/src/org/netbeans/modules/html/editor/hints/HtmlRule.java

Lines 60 to 63 in a8edf3b

@Override

public String getId() {

return getClass().getSimpleName();

}

You also need to define a message named AddMissingAltAttributeRule_Desc (you get an exception when you click on the hint in the option panel):

netbeans/ide/html.editor/src/org/netbeans/modules/html/editor/hints/HtmlRule.java

Lines 65 to 68 in a8edf3b

@Override

public String getDescription() {

return NbBundle.getMessage(HtmlRule.class, String.format("%s_Desc", getId()));

}

I suggest to use : Provide Text Alternatives for the display name (to get it more in line with the rest of the entries) and Find img/applet/area elements where no alt attribute is provided. (for the description)

matthiasblaesing · 2022-12-19T20:50:04Z

I left a few inline comments, but I made a general observation, that the integration looks a bit strange right now:

As you can see, I get an error indicator for the img-Tag, but I don't get the fixes. To get these I have to click inside the range of img-Tag:

I think this should be made consistent.

This can be ignored, as there are two hints/rules active here:

the HTML validator marks the whole element as error
your new rule, which indeed only applies for the elements

When I deactivate the corresponding "All Other" category, I get the desired behavior, so is ok.

Chris2011 · 2022-12-20T15:07:34Z

@matthiasblaesing thx for your comments, will fix them :)

matthiasblaesing · 2023-04-10T20:06:02Z

@Chris2011 NB18 is coming nearer. Shall this stay on the NB18 milestone, then an update would be good now (branch happens in 8 days) or moving to NB 19 should be considered.

ide/html.editor/src/org/netbeans/modules/html/editor/utils/HtmlTagContextUtils.java

Chris2011 · 2023-04-11T08:21:10Z

@Chris2011 NB18 is coming nearer. Shall this stay on the NB18 milestone, then an update would be good now (branch happens in 8 days) or moving to NB 19 should be considered.

We should remove the label completely. I have one bug there when it is a warning instead of a suggestion and I need to figure that out first. I had a look into my other PRs and I wanted to focus on another one first. Step by step. @matthiasblaesing thx for catching this up again :)

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

ide/html.editor/src/org/netbeans/modules/html/editor/hints/other/AltAttributeVisitor.java

ide/html.editor/src/org/netbeans/modules/html/editor/utils/HtmlTagContextUtils.java

junichi11 · 2023-08-24T04:01:21Z

Please write an example code to verify this in the description.

Please add unit tests. (CslTestBase has checkHints() and applyHint())

Chris2011 · 2023-08-24T06:29:51Z

Please write an example code to verify this in the description.

Please add unit tests. (CslTestBase has checkHints() and applyHint())

Thx, I was searching for this. Will check it out.

Chris2011 · 2023-08-24T20:02:04Z

Tests still missing, I'm on it. Thx for all the information.

junichi11 · 2023-08-24T22:41:30Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+
+                    source.getDocument(false).insertString(adjustContextRange.getEnd(), " alt=\"\"", null); // NOI18N
+                } catch (BadLocationException ex) {
+                    LOGGER.log(Level.SEVERE, ex.getMessage());


Suggested change

LOGGER.log(Level.SEVERE, ex.getMessage());

LOGGER.log(Level.WARNING, "Invalid offset: {0}", ex.offsetRequested()); // NOI18N

junichi11 · 2023-08-24T22:58:08Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+ */
+public class AddMissingAltAttributeRule extends HtmlRule {
+
+    public static AddMissingAltAttributeRule SINGLETON = new AddMissingAltAttributeRule();


Suggested change

public static AddMissingAltAttributeRule SINGLETON = new AddMissingAltAttributeRule();

private static AddMissingAltAttributeRule INSTANCE = new AddMissingAltAttributeRule();

private AddMissingAltAttributeRule() {

}

public static AddMissingAltAttributeRule getInstance() {

return INSTANCE;

}

BTW, Please note that we have to make it thread-safe if we make this class singleton.

junichi11 · 2023-08-24T22:58:24Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeRule.java

+    protected void run(HtmlRuleContext context, List<Hint> result) {
+        try {
+            HtmlParserResult parserResult = context.getHtmlParserResult();
+            AltAttributeVisitor visitor = new AltAttributeVisitor(this, context, result, "img|applet|area");


// NOI18N

matthiasblaesing

Am I missing something obvious here? The Rule/Hint is not registered anywhere and running a build under debugger and having a break point inside them, they are not hit. So I'm not sure what I should be seeing.

This:

Is generated in the html validator module, in the ProblemHandler:

With this change applied:

--- a/ide/html.editor/src/org/netbeans/modules/html/editor/resources/layer.xml
+++ b/ide/html.editor/src/org/netbeans/modules/html/editor/resources/layer.xml
@@ -534,6 +534,9 @@
                         <file name="org-netbeans-modules-html-editor-hints-NotValidatedContent.instance">
                             <attr name="position" intvalue="190"/>                            
                         </file>
+                        <file name="org-netbeans-modules-html-editor-hints-other-AddMissingAltAttributeRule.instance">
+                            <attr name="position" intvalue="200"/>
+                        </file>
                         <!-- the following hint 'Other' must be last in the hints list!!! -->
                         <file name="org-netbeans-modules-html-editor-hints-Other.instance">
                             <attr name="position" intvalue="99999"/>

I get two matches, one from the html validator, one from this new hint (with the fix):

With the full parser result available the visitor can be simplified to (range now includes "/>", but that can be accounted for), at least I'm missing an argument to redo the scanning the parser already did.

public class AltAttributeVisitor implements ElementVisitor {

    private static final String ALT_ATTR = "alt"; // NOI18N

    private final HtmlRuleContext context;
    private final List<Hint> hints;

    public AltAttributeVisitor(Rule rule, HtmlRuleContext context, List<Hint> hints) throws IOException {
        this.context = context;
        this.hints = hints;
    }

    @Override
    public void visit(Element node) {
        // We should only be invoked for opening tags
        if(! (node instanceof OpenTag)) {
            return;
        }
        // We are only interested in img, area, applet elements
        String lowerCaseTag = node.id().toString().toLowerCase();
        if(! (lowerCaseTag.equals("img") || lowerCaseTag.equals("area") || lowerCaseTag.equals("applet"))) {
            return;
        }

        OpenTag ot = (OpenTag) node;
        if(ot.getAttribute(ALT_ATTR) == null) {
            hints.add(new AddMissingAltAttributeHint(context, new OffsetRange(node.from(), node.to())));
        }
    }
}

I also notice, that the fix should check, if new whitespace needs to be inserted. If you have this case <img src="..." /> this fix will change it to <img src="..." alt=""/> (there are now two spaces)

Chris2011 · 2023-08-30T19:52:29Z

Thx for your review @matthiasblaesing. Yes I already encountered the missing xml part but this was done by a merge because I already had it. I didn't have a merge conflict but it was removed accidentally. And indeed this is why we need tests for this. So I changed this now back to draft, because I already created the first test but it is still red due to not triggering the warning/suggestion handled as a error. After this I will change this back to normal.

Also I will have a look into the part that you wrote with the visit method change and the new added empty space. Thx.

…alt-attribute-hint-fix

…ests area failing

…alt-attribute-hint-fix

Chris2011 · 2024-01-26T20:35:20Z

It is still in draft mode but can please someone have a look into my test impl? @junichi11 or @matthiasblaesing. For checkHints I needed to make a change in the CslTestBase but I'm not 100% sure whether I needed to do this or not. w/o my change the problem was that the hint was never triggered due to not writing the correct property for hints/suggestions (L4387: https://github.com/apache/netbeans/pull/4485/files#diff-afbe604d62e2e9bec89e4ed0e712ad047106ed77e63c2c4030e76a54d762941fR4387).

For the applyHint test, I also needed to change code within the CslTestBase in the method findApplicableFix (L4624: https://github.com/apache/netbeans/pull/4485/files#diff-afbe604d62e2e9bec89e4ed0e712ad047106ed77e63c2c4030e76a54d762941fR4624) from text == null to text != null. I'm also not 100% sure but the code makes more sense for me now. Otherwise it will always return null which breaks the code in applyHint (assertNotNull(fix))- This test is also funny, often it fails with that the expectation of the result is not the correct one but when I debug 1min or so with F8 to jump over the code, etc. it says that the test is green and I don't know what's wrong here.

I also added a check for Error and Warning which was missing, because if Current_line_warning is false it is not that the rest is always an error or an warning. computeHints maybe is missnamed here. It will just check for html version, nothing else. So all in all the code is often very frustrating to check and I needed days for debugging and yes it could be that I don't understand the code 100% that's why I'm asking for a bit of help please. Thanks all.

Chris2011 · 2024-01-30T14:59:19Z

Unfortunately I see that my changes break some PHP tests. Will dig into it again and would be happy to have someone that helps me break it down what I missed.

matthiasblaesing · 2024-02-05T19:36:09Z

My gut feeling is, that the HtmlHintsProvider and the expectations of the CslTestBase/GsfHintsManager don't match. It seems suggestions were never really supported. It might be worthy looking into JS/CSS whether there are suggestions being checked. I'm not sure, that modifying CslTestBase is really a good idea.

General comments:

The unstable test you observed is because you dispatch the text change into another thread (org.netbeans.modules.html.editor.hints.other.AddMissingAltAttributeHint.AddMissingAltAttributeHintFix.implement(). That (a) makes it unstable and is IMHO wrong. I suggest to adjust to this:

    @Override
    public void implement() throws Exception {
        BaseDocument document = (BaseDocument) context.getSnapshot().getSource().getDocument(true);
        document.runAtomic(() -> {
            try {
                OffsetRange adjustedRange = HtmlTagContextUtils.adjustContextRange(document, range.getStart(), range.getEnd(), true);
                String tagContent = document.getText(adjustedRange.getStart(), adjustedRange.getLength());

                // Find last self-closing or non self-closing tag
                Pattern closingTagPattern = Pattern.compile("(/?>)");
                Matcher closingTagMatcher = closingTagPattern.matcher(tagContent);

                if (closingTagMatcher.find()) {
                    int altInsertPosition = adjustedRange.getStart() + closingTagMatcher.start(1);

                    // Check whether a space before alt is needed or not
                    boolean needsSpaceBefore = altInsertPosition == 0 || tagContent.charAt(closingTagMatcher.start(1) - 1) != ' ';
                    boolean isSelfClosing = closingTagMatcher.group(0).endsWith("/>");
                    String altAttribute = (needsSpaceBefore ? " " : "") + "alt=\"\"" + (isSelfClosing ? " " : ""); // NOI18N

                    document.insertString(altInsertPosition, altAttribute, null);
                }
            } catch (BadLocationException ex) {
                // Ignore
            }
        });
    }

There is no need to do this on the EDT. The locking infrastructure of the documents should handle this.

The null check in CslTestBase#findApplicableFix begins to make sense, when you write it like this:

The only difference compared to master is in line 4603, 4621 is only modified when comparing with your version.

Then org.netbeans.modules.csl.api.test.CslTestBase.applyHint(NbTestCase, Rule, String, String, String) can be called with null as final parameter, which would invoke the found fix without checking for the description.
Merges make it hard to compare against the base revision. Until this is changed incrementally/being reviewed I suggest to either not merge master or use rebases to cleanup/update.

Chris2011 · 2024-02-05T19:44:48Z

My gut feeling is, that the HtmlHintsProvider and the expectations of the CslTestBase/GsfHintsManager don't match. It seems suggestions were never really supported. It might be worthy looking into JS/CSS whether there are suggestions being checked. I'm not sure, that modifying CslTestBase is really a good idea.

Hey @matthiasblaesing thx for your info and hint. I'm definitely with you, I will check the JS stuff, because CSS has also no real hints/fixes (just basic stuff) as I have. I also thought that this was never tried before. Lemme check more what I can do.

For the invokeLater, thx for the hint with the change, I got this from ExtractInlinedStyleHint but due to I not doing extrem things like opening a new UI, it is not needed here. I just add stuff into the editor.

Revert change inside the CslTestBase for findApplicableFix

Chris2011 · 2024-02-21T22:14:02Z

@matthiasblaesing so another research here:

There are no CSS Hints/Suggestions/Fixes, etc, just the CssHintsProvider where the computeHints, computeSuggestions and computeSelectionHints method bodies are empty. I already have one CSS hint/suggestion on another branch, just to test smth but without any test.
The best implementation that I found is the PHP stuff for suggestions, but the problem is that I get a timeout when I try to run a PHP related suggestion test like this one locally: https://github.com/apache/netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/verification/InitializeFieldsSuggestionTest.java and on my branch, on the pipeline, the tests are not executed/skipped, but maybe because of the failing latte tests.
I also had a look into JsHintsProvider and JsHints. There is just one fix, changing the EcmaLevel but everything seems a warning. The tests will not work with suggestions. There will be a Parse exception, when I change the severity warning to a current_line_waning. Ok I really don't know whether I need to change smth else.

Fazit: It seems PHP and maybe JS are better implemented in their *HintsProvider and I need to change the whole logik of the HtmlHintsProvider but JS also lacks of tests and suggestions are also not a big player for JS (not yet). Should this be part of this ticket? I guess not.

I also think that we should make this somehow consistent for all CSL languages as good as possible. PHP uses Classes for like SuggestionRule, HintRule and ErrorRule, which just set the severity to the correct one and so on. ~~So probably I will create another PR with the "fx" of the HtmlHintsProvider with using Tests~~. I will ake the refactoring in this PR because I already have a Suggestion here.

I think I ran into a rabbithole and yes, it is not your business but the code is a big mess and I want to rework it and hope to not break more than before. Any other thoughts/suggestions/hints? :D

matthiasblaesing · 2024-03-03T19:21:36Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+ */
+package org.netbeans.modules.html.editor.hints.other;
+
+import java.awt.EventQueue;


Unnecessary import

matthiasblaesing · 2024-03-03T19:21:45Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import javax.swing.text.BadLocationException;
+import javax.swing.text.Document;


Unnecessary import

You mean, they are unnecessary, when I change the logik, right? Because atm I need them.

Neither Document, nor Source are used. I admit, that I only noticed that because NetBeans marked these:

Yes, those three are correct marked as not used, but your both other comments have different lines. That's why I'm asking. It was about the matcher, pattern, the exception, etc. That's why I was confused about it.

matthiasblaesing · 2024-03-03T19:21:54Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+import org.netbeans.modules.csl.api.OffsetRange;
+import org.netbeans.modules.html.editor.hints.HtmlRuleContext;
+import org.netbeans.modules.html.editor.utils.HtmlTagContextUtils;
+import org.netbeans.modules.parsing.api.Source;


Unnecessary import

Same as above

matthiasblaesing · 2024-03-03T19:23:51Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+        HtmlRuleContext context;
+        OffsetRange range;


These can be private and final

matthiasblaesing · 2024-03-03T19:42:04Z

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java

+                    Matcher closingTagMatcher = closingTagPattern.matcher(tagContent);
+
+                    if (closingTagMatcher.find()) {
+                        int altInsertPosition = adjustedRange.getStart() + closingTagMatcher.start(1);


This might lead to wrong results. Consider PHP with embedded HTML. The document could look like this:

<img src='demo.png' alt='<?php echo htmlspecialchars('x > y');?>' />

I would use the HTML token stream and either use the start of the closing token or, if that does not exist, the start of the last HTML token + length.

TBH, I didn't try PHP yet, will do it too. Thx for the hint. If I guess it correct, your example will not trigger the hint, because you already have the alt attribute. But yes It would be better to take the HTML token instead of just looking for the closing tag symbol with an regex.

matthiasblaesing · 2024-03-03T19:44:21Z

ide/csl.api/test/unit/src/org/netbeans/modules/csl/api/test/CslTestBase.java

                            provider.computeSuggestions(manager, context, hints, caretOffset);
+                        } else if(HintsSettings.getSeverity(manager, ucr) == HintSeverity.ERROR || HintsSettings.getSeverity(manager, ucr) == HintSeverity.WARNING) {
+                            manager.setTestingRules(null, testHints, testHints, null);
+                            provider.computeErrors(manager, context, hints, new ArrayList<Error>());


Did you test, that all current tests invoking computeHints, potentially transitively, still work?

No, not yet. I just thought that the pipes will show me the result and I just saw some failing tests of Latte. PHP where not triggert here at github inside my branch. I will just revert this change as you said and will try to implement a better logic into the HtmlHintsProvider as similiar as for PHP and JS.

…alt-attribute-hint-fix

Chris2011 added HTML [ci] enable web job hints labels Aug 8, 2022

Chris2011 requested review from matthiasblaesing and neilcsmith-net August 8, 2022 19:53

Chris2011 marked this pull request as draft August 8, 2022 19:53

mbien reviewed Aug 9, 2022

View reviewed changes

...beans/modules/html/editor/hints/other/AddMissingAltAttribute/AddMissingAltAttributeHint.java Outdated Show resolved Hide resolved

Chris2011 force-pushed the add-alt-attribute-hint-fix branch 2 times, most recently from 14399b1 to db09843 Compare August 9, 2022 20:26

Chris2011 requested a review from mbien August 9, 2022 20:26

Chris2011 marked this pull request as ready for review August 10, 2022 07:05

matthiasblaesing reviewed Aug 10, 2022

View reviewed changes

Chris2011 force-pushed the add-alt-attribute-hint-fix branch from 7065b3e to db09843 Compare December 18, 2022 21:54

Chris2011 requested a review from matthiasblaesing December 18, 2022 22:29

matthiasblaesing reviewed Dec 19, 2022

View reviewed changes

mbien added this to the NB18 milestone Jan 14, 2023

junichi11 reviewed Apr 11, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/utils/HtmlTagContextUtils.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

...html.editor/src/org/netbeans/modules/html/editor/hints/other/AddMissingAltAttributeHint.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/hints/other/AltAttributeVisitor.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/hints/other/AltAttributeVisitor.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/hints/other/AltAttributeVisitor.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/hints/other/AltAttributeVisitor.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/utils/HtmlTagContextUtils.java Outdated Show resolved Hide resolved

junichi11 reviewed Aug 24, 2023

View reviewed changes

ide/html.editor/src/org/netbeans/modules/html/editor/utils/HtmlTagContextUtils.java Show resolved Hide resolved

Add NOI18N, null checks and clean up as requested

c7fb071

junichi11 reviewed Aug 24, 2023

View reviewed changes

matthiasblaesing reviewed Aug 30, 2023

View reviewed changes

Chris2011 marked this pull request as draft August 30, 2023 19:48

clenz and others added 5 commits October 7, 2023 12:44

Merge branch 'master' of https://github.com/apache/netbeans into add-…

07405c3

…alt-attribute-hint-fix

Add test for the new hint as requested

ff1fd4e

Merge branch 'master' of https://github.com/apache/netbeans into add-…

b2055c9

…alt-attribute-hint-fix

Add test for hintfix too and change test code to figure out why the t…

09d31d9

…ests area failing

Merge branch 'master' of https://github.com/apache/netbeans into add-…

d54d461

…alt-attribute-hint-fix

Fix missing test for applying the hint due to removing EDT logic.

f5ebc51

Revert change inside the CslTestBase for findApplicableFix

matthiasblaesing reviewed Mar 3, 2024

View reviewed changes

Merge branch 'master' of https://github.com/apache/netbeans into add-…

ee1a6d9

…alt-attribute-hint-fix

	@Override
	public String getDisplayName() {
	return NbBundle.getMessage(HtmlRule.class, getId());
	}

	@Override
	public String getId() {
	return getClass().getSimpleName();
	}

	@Override
	public String getDescription() {
	return NbBundle.getMessage(HtmlRule.class, String.format("%s_Desc", getId()));
	}

	LOGGER.log(Level.SEVERE, ex.getMessage());
	LOGGER.log(Level.WARNING, "Invalid offset: {0}", ex.offsetRequested()); // NOI18N

-    public static AddMissingAltAttributeRule SINGLETON = new AddMissingAltAttributeRule();
+    private static AddMissingAltAttributeRule INSTANCE = new AddMissingAltAttributeRule();
+    private AddMissingAltAttributeRule() {
+    }
+    public static AddMissingAltAttributeRule getInstance() {
+        return INSTANCE;
+    }

Add HTML rule and hint+fix for missing alt attribute for tag img, applet and area #4485

Are you sure you want to change the base?

Add HTML rule and hint+fix for missing alt attribute for tag img, applet and area #4485

Conversation

Chris2011 commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Chris2011 commented Aug 8, 2022

Uh oh!

Uh oh!

Chris2011 commented Aug 9, 2022

Uh oh!

Chris2011 commented Aug 10, 2022

Uh oh!

mbien commented Aug 10, 2022

Uh oh!

matthiasblaesing left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chris2011 commented Aug 11, 2022

Uh oh!

Chris2011 commented Aug 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Chris2011 commented Dec 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiasblaesing commented Dec 18, 2022

Uh oh!

Chris2011 commented Dec 18, 2022

Uh oh!

Chris2011 commented Dec 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiasblaesing left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthiasblaesing commented Dec 19, 2022

Uh oh!

Chris2011 commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiasblaesing commented Apr 10, 2023

Uh oh!

Uh oh!

Chris2011 commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

junichi11 commented Aug 24, 2023

Uh oh!

Chris2011 commented Aug 24, 2023

Uh oh!

Chris2011 commented Aug 24, 2023

Uh oh!

junichi11 Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chris2011 commented Aug 8, 2022 •

edited

Loading

Chris2011 commented Aug 13, 2022 •

edited

Loading

Chris2011 commented Dec 6, 2022 •

edited

Loading

Chris2011 commented Dec 18, 2022 •

edited

Loading

Chris2011 commented Dec 20, 2022 •

edited

Loading

Chris2011 commented Apr 11, 2023 •

edited

Loading

junichi11 Aug 24, 2023 •

edited

Loading

Chris2011 commented Aug 30, 2023 •

edited

Loading

Chris2011 commented Feb 21, 2024 •

edited

Loading