Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI)

[eirikbakke]

The loadImage(URI) method was added in #8114 , as part of a broader consolidation of various icon loading methods. After seeing one log message, we see that both the nbres: and nbresloc: protocols should be handled, not just nbresloc. The difference is in whether a given file should be loaded with localization suffixes or not, per this API documentation.

The log message in question was as follows:
WARNING [org.openide.util.ImageUtilities]: loadImage(URI) called with unusual URI: nbres:/org/netbeans/modules/form/resources/palette/panel_16.png

This PR adds handling of the nbres case, and changes the handling of the nbresloc case to enable loading with localization.

A quick test of the IDE saw no new problems, including in the Matisse form builder.

[mbien]

looks good, thanks @eirikbakke!

[mbien]

btw good that you added the log warnings in the original PR, otherwise we probably wouldn't have noticed this ;)

[eirikbakke]

True! But either way it falls back to the old method that was used to load icons from URLs. It might have missed a localization, or used a bitmap icon instead of an SVG.

[eirikbakke]

I did see this similar log warning, but could not immediately figure out what the "ergoloc" protocol was:

WARNING [org.openide.util.ImageUtilities]: loadImage(URI) called with unusual URI: ergoloc:/org/netbeans/modules/ide/ergonomics/enterprise/org-netbeans-modules-websvc-core-client-resources-ws_client_16.png

[mbien]

ergoloc sounds ergonomics related. The mechanism which activates clusters when certain wizard entries are hit etc.
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20ergoloc&type=code seems like it isn't used much though

[eirikbakke]

Yeah, I'm just not sure whether ImageUtilities should do anything about it. We could exempt the warning message in case of an "ergoloc" protocol, but then I feel like we should know if it is actually working first...

[mbien]

Other than ergoloc being a strange device trying to help with back pain I don't know anything about it + it seems to be not used for icons. Lets get this PR in :)

[eirikbakke]

Thanks for reporting the log message!