Skip to content

Conversation

@junichi11
Copy link
Member

@junichi11 junichi11 commented Feb 16, 2025


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

- apache#8244
- Scan attributes after `ConstantDeclaration`s are scanned
@junichi11 junichi11 added the PHP [ci] enable extra PHP tests (php/php.editor) label Feb 16, 2025
@junichi11 junichi11 added this to the NB26 milestone Feb 16, 2025
@junichi11 junichi11 requested a review from tmysik April 13, 2025 06:11
@junichi11 junichi11 merged commit 6f2a1ee into apache:master Apr 13, 2025
32 checks passed
@junichi11 junichi11 deleted the gh-8244-incorrect-unused-constants branch April 13, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP [ci] enable extra PHP tests (php/php.editor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Private const properties get marked as unused when used in attributes

2 participants