Skip to content

Attempted clipboard issue workaround on Windows #8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eirikbakke wants to merge 1 commit into from
Closed

Attempted clipboard issue workaround on Windows #8277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions platform/o.n.bootstrap/src/org/netbeans/NbClipboard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,10 @@
import java.awt.event.AWTEventListener;
import java.awt.event.WindowEvent;
import java.io.IOException;
import java.lang.ref.Reference;
import java.lang.ref.WeakReference;
import java.util.Collection;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.swing.SwingUtilities;
import org.openide.util.Exceptions;
import org.openide.util.Lookup;
import org.openide.util.LookupEvent;
Expand Down Expand Up @@ -258,10 +257,13 @@ public synchronized void addFlavorListener(FlavorListener listener) {
}
}



private void scheduleSetContents(final Transferable cnts, final ClipboardOwner ownr, int delay) {
setContentsTask = RP.post(new SetContents(cnts, ownr), delay);
SetContents setContentsRunnable = new SetContents(cnts, ownr);
if (setContentsRunnable.onEventDispatchThread && delay == 0) {
setContentsRunnable.run();
} else {
setContentsTask = RP.post(setContentsRunnable, delay);
}
}

@SuppressWarnings("NestedAssignment")
Expand Down Expand Up @@ -466,14 +468,18 @@ public void run() {
private final class SetContents implements Runnable {
private final Transferable cnts;
private final ClipboardOwner ownr;
public boolean onEventDispatchThread;

SetContents(Transferable cnts, ClipboardOwner ownr) {
this.cnts = cnts;
this.ownr = ownr;
/* The JDK's Clipboard implementation on Windows may not be fully thread-safe. Try to
work around the issues discussed in https://github.com/apache/netbeans/discussions/7051
by always running setContents on the EDT on Windows. */
this.onEventDispatchThread = Utilities.isWindows();
}

@Override
public void run() {
private void runImpl() {
try {
systemClipboard.setContents(cnts, ownr);
} catch (IllegalStateException e) {
Expand All @@ -491,5 +497,16 @@ public void run() {
logFlavors(cnts, Level.FINE, log.isLoggable(Level.FINEST));
}
}

@Override
public void run() {
if (onEventDispatchThread) {
SwingUtilities.invokeLater(() -> {
runImpl();
});
} else {
runImpl();
}
}
}
}
Loading