Maven should not filter out non-jrt URLs from Java platform modular BCP. #8538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
the
Java
mbien
added
Maven
Member
|
adding platform and maven tests and restarting CI |
Member
|
how do you add the exploded folder as JDK? I believe the only thing which worked for me in past was to add the image output in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing module boot path, the Maven provider filters out URLs that are not
nbjrtURLs. That does not make much sense to me, and it does not work for exploded JDK builds (which have classfiles in directories on the filesystem, not in the JRT file system).I propose to simply use whatever bootstrap libraries the platform provides, and not filter them.