Skip to content

Conversation

@BradWalker
Copy link
Member

@BradWalker BradWalker commented Dec 26, 2025

cleanup: Remove securityManager use on startup

desc: This change removes the use of securityManager on startup of netbeans. This is a fairly simple change but had far reaching impacts as it deals w/ startup. For this reason, I created this change just for this issue.

In addition, as I read the code, netbeans.jnlp.fixPolicy is always false. Meaning the fixPolicy() will never execute.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

desc: This change removes the use of securityManager on startup of netbeans. This is a fairly simple change but had far reaching impacts as it deals w/ startup. For this reason, I created this change just for this issue.
@BradWalker BradWalker self-assigned this Dec 26, 2025
@BradWalker BradWalker added Code cleanup Label for cleanup done on the Netbeans IDE ci:all-tests [ci] enable all tests labels Dec 26, 2025
@mbien
Copy link
Member

mbien commented Dec 29, 2025

netbeans.jnlp.fixPolicy is always false. Meaning the fixPolicy() will never execute.

JNLP is part of webstart/applets. So yes this code (jnlp-src/*, which includes the Main class itself) won't run during regular NB startup.

This means that the PR title and the commit message makes a somewhat misleading promise. It might be better to delay removal of this specific SM usage and remove the JNLP integration entirely later (without breaking it via small paper cuts). (although I believe its unlikely that anyone is still using this)

Curious what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests Code cleanup Label for cleanup done on the Netbeans IDE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants