NIFI-14374 Set Deterministic Order for Manifest Documentation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sorted Relationship documentation elements based on name field - Sorted Resource Type documentation elements based on enumeration name method - Sorted Property Dependencies based on dependent Property Name - Sorted Dependent Values based on natural String ordering
dan-s1
reviewed
Mar 17, 2025
src/main/java/org/apache/nifi/documentation/xml/XmlDocumentationWriter.java
Outdated
Show resolved
Hide resolved
pvillard31
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14374 Sets deterministic ordering for several unordered elements in the Extension Manifest XML Documentation.
Changes to the
XmlDocumentWriterinclude adding sorting to the following unordered collections:namefieldnamemethodThese changes retain compatibility with current output formatting, but provide deterministic behavior for the ordered elements. Deterministic ordering is a requirement for reproducible builds and these changes address issues related to
extension-manifest.xmlidentified in with a comparison of Apache NiFi 2.3.0.Changes include a new unit test for the
XmlDocumentWriterthat verifies expected ordering.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch