NIFI-15104 - Populate Bulletin's stackTrace and expose it to the bulletin board #10431
+290
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for implementing the stack trace propagation for Bulletins @pvillard31. The implementation looks good in general, just a few minor notes, mostly related to tests.
...-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/events/BulletinFactory.java
Outdated
Show resolved
Hide resolved
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class BulletinFactoryStackTraceTest { |
Contributor
There was a problem hiding this comment.
Minor formatting bit, the public modifiers are not needed on the class or method level in JUnit 5 tests.
...i-framework-core-api/src/test/java/org/apache/nifi/events/BulletinFactoryStackTraceTest.java
Outdated
Show resolved
Hide resolved
...rk/nifi-framework-core/src/test/java/org/apache/nifi/jaxb/BulletinAdapterStackTraceTest.java
Outdated
Show resolved
Hide resolved
...rk/nifi-framework-core/src/test/java/org/apache/nifi/jaxb/BulletinAdapterStackTraceTest.java
Outdated
Show resolved
Hide resolved
| * @param bulletin bulletin | ||
| * @return dto | ||
| */ | ||
| public BulletinDTO createBulletinDto(final Bulletin bulletin) { |
Contributor
There was a problem hiding this comment.
Is it necessary to retain this method? It might be better to remove this signature to make sure all references explicitly declare whether to include stack traces.
...nifi-web-api/src/test/java/org/apache/nifi/web/api/dto/DtoFactoryBulletinStackTraceTest.java
Outdated
Show resolved
Hide resolved
exceptionfactory
approved these changes
Oct 17, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments, looks good! +1 merging
awelless
pushed a commit
to awelless/nifi
that referenced
this pull request
Nov 5, 2025
…e#10431) Signed-off-by: David Handermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15104 - Populate Bulletin's stackTrace and expose it to the bulletin board
This change is required for #10343.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation