[dan-s1]

Summary

NIFI-16190

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
• Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[exceptionfactory]

Thanks for addressing this issue @dan-s1, I noted some minor details related to logging, but the approach looks good.

[dan-s1]

@exceptionfactory Per your suggestion, the line number is zero based. Would it make sense to make it 1 based i.e.

getLogger().debug("JSLT Transform resulted in no data on line {}", lines + 1);

?

[exceptionfactory]

@exceptionfactory Per your suggestion, the line number is zero based. Would it make sense to make it 1 based i.e.

getLogger().debug("JSLT Transform resulted in no data on line {}", lines + 1);

?

Yes, good call, I agree

[dan-s1]

@exceptionfactory Can you please take another look to see if there is anything else that needs to be changed? Thanks!

[exceptionfactory]

Thanks @dan-s1, I noted two remaining items to address

[exceptionfactory]

Looks good @dan-s1, just one more adjustment to correct the debug log line now

[exceptionfactory]

Thanks for working through all the adjustments @dan-s1, the latest version looks good to go pending successful build completion.