drivers/wireless/lpwan/rn2xx3: Patch read operation #17291
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue with the read operation where sometimes the `file_read` call would return a single ASCII hex byte instead of 2 and the parsing logic could not handle that scenario. Now packet data is read in large chunks to an internal buffer and incrementally parsed, making it robust to this problem (and likely much faster). Signed-off-by: Matteo Golin <[email protected]>
github-actions
bot
added
Area: Drivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This patch fixes an issue with the read operation where sometimes the
file_readcall would return a single ASCII hex byte instead of 2 and the parsing logic could not handle that scenario. Now packet data is read in large chunks to an internal buffer and incrementally parsed, making it robust to this problem (and likely much faster).Closes #17273.
Impact
The driver implementation should no longer have this read bug, and read operations should be faster. This is a change to the internal implementation, doesn't touch documentation or build system.
Testing
Only verified that the code compiles without warnings/errors using the
raspberrypi-pico:usbnshconfiguration with the driver enabled.Waiting for fix confirmation from @bskdany after device testing, marked as draft until then.