fix(services-aws-v4): Ensure token has been trimmed and encoded #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
tisonkun
approved these changes
Oct 13, 2025
Merged
Xuanwo
added a commit
that referenced
this pull request
Oct 21, 2025
This PR will bump reqsign version to 0.18.1 All other crates bumped to 2.0.1 ## Summary - Enabled reqsign-http-send-reqwest and reqsign-file-read-tokio to build on WASM, tightening cross-platform coverage. - Improved credential handling by returning credential_invalid when no credential is available and trimming/encoding AWS tokens correctly. - Aligned internal crate versions for the 0.18.1/2.0.1 release and fixed the release workflow. ## Commits - bd9eee5 Bump version to 0.18.1 - 4997eef feat: Make http-send-reqwest available on wasm (#656) - 125362c feat: Return credential_invalid while no credential found (#655) - c7953e5 feat(context-file-read-tokio): Allow file read tokio been built on wasm (#654) - 1744efc fix(services-aws-v4): Ensure token has been trimmed and encoded (#653) - 60d1ca9 ci: fix up release workflow (#650) --- **This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.** Signed-off-by: Xuanwo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of apache/opendal#6656
In the real world, token files may contain non-URL-safe characters. This PR handles them by trimming and encoding the tokens before sending them out.