Skip to content

plc4j(ab-eth): Fix read tag after refactoring/spi3 #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisdutz merged 1 commit into from
Jun 18, 2026
+2 −2
Merged

plc4j(ab-eth): Fix read tag after refactoring/spi3 #2606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plc4j/drivers/ab-eth/src/main/java/org/apache/plc4x/java/abeth/AbEthMessageCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ protected int getMinimumHeaderSize() {

@Override
protected int calculateTotalMessageSize(byte[] header, int availableBytes) throws MessageCodecException {
// Little-endian unsigned 16-bit at offset 2
int payloadLength = (header[LENGTH_OFFSET] & 0xFF) | ((header[LENGTH_OFFSET + 1] & 0xFF) << 8);
// Big-endian unsigned 16-bit at offset 2
int payloadLength = ((header[LENGTH_OFFSET] & 0xFF) << 8) | (header[LENGTH_OFFSET + 1] & 0xFF);
return payloadLength + HEADER_OVERHEAD;
}

Expand Down
Loading