Open
Conversation
pjfanning
reviewed
Apr 7, 2026
| * @see #doubleCell(String, double, Comment, ExcelNumberFormat) | ||
| */ | ||
| void stringCell(String cellReference, String value, XSSFComment comment); | ||
| void stringCell(String cellReference, String value, Comment comment); |
Member
There was a problem hiding this comment.
these are breaking changes - we have a policy of deprecating APIs and later removing them
Can we keep the XSSFComment methods and deprecate them adding the Comment overloads?
Add @Removal annotation to the deprecated methods (v7.0.0 removal). @since 6.0.0 to the new methods.
If methods are not public then it is ok to change them without this deprecate and overload approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to decouple xmlbeans from xlsb.
The one area of concern I have is the public api change:
XSSFSheetXMLHandler.SheetContentsHandler.cell(String, String, XSSFComment) → cell(String, String, Comment)
This is:
If this is a bridge too far, we can try to refactor in another way.