Adapt to latest Asio APIs (Asio 1.32 or Boost.Asio 1.88) #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oversearch
added a commit
to oversearch/pulsar-client-cpp
that referenced
this pull request
Apr 9, 2025
This was introduced in v3.7.0 via apache#477. which contained a change that attempted to fix an issue where a pre-mature ack of a message before a multi-topic subscriber was ready could have caused a crash. To fix the original bug, all multi-topic subscriptions are started with their message listener paused. They later get un-paused once all topics are successfully subscribed and connected. However, on a regex subscription when new topics are discovered, they also start in a paused state, and there's no mechanism to resume them. Hence, they get stuck, and no messages for new topics will be processed. This change adds a call to resume any new listeners after new topics are added. The fix has been deployed to production in my company's infrastructure and has been confirmed working for a few weeks.
4 tasks
carlocab
added a commit
to Homebrew/formula-patches
that referenced
this pull request
Aug 5, 2025
7 tasks
BewareMyPower
force-pushed
the
bewaremypower/boost-compatibility
branch
from
cc30a7b to
c7eae14
Compare
Closed
2 tasks
BewareMyPower
changed the title
merlimat
approved these changes
Oct 3, 2025
BewareMyPower
added a commit
that referenced
this pull request
Oct 13, 2025
(cherry picked from commit f2f9f65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #475
Motivation
There were some breaking changes with Boost.Asio APIs so that the code base is incompatible with the latest Boost.Asio.
Modifications
async_connectmethod with theasync_connectfunction that accepts the list of endpoints from the latestasync_resolvemethod. This also simplifies the code that it no longer needs to manually retry each endpoint, which might fix the issue like [Bug] C++ client cannot switch IPs when serviceUrl is a domain name with multiple resolved IPs #502io_servicewithio_contextio_service::workwithmake_work_guardexpires_from_nowwithexpires_afterforsteady_timer, a wrappedcancelTimerfunction is used to simplify thetry-catchclauserfc2818_verificationwithhost_name_verificationBOOST_VERSIONconditional compilation, which makes code hard to maintain due to the Asio API compatibility changes.