Conversation
There was a problem hiding this comment.
Pull request overview
Adds configurable support for injecting additional sidecar containers into the SkyWalking OAP Deployment, allowing users to extend the OAP pod with auxiliary components (e.g., proxies or log shippers) via Helm values.
Changes:
- Introduces a new
oap.sidecarsvalues field (default empty) with inline documentation and an example. - Updates the OAP Deployment template to append the configured sidecars to the pod’s
containerslist (rendered viatpl). - Documents the new value in the chart README parameter table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chart/skywalking/values.yaml | Adds the oap.sidecars values entry with guidance and an example sidecar spec. |
| chart/skywalking/templates/oap-deployment.yaml | Renders oap.sidecars into the OAP pod containers list via tpl(toYaml ...). |
| chart/skywalking/README.md | Documents oap.sidecars in the configuration table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.