Repository navigation
WW-3464 docs: the first matching wildcard mapping wins - #349
Merged
Merged
Conversation
The framework resolves XML wildcard action mappings to the first pattern that matches, in declaration order; the page claimed the last one wins and gave the placement advice backwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WW-3464
Summary
core-developers/wildcard-mappings.mdsaid that when several wildcard mappings match, the last one wins and that less specific patterns must come first. The framework does the opposite:AbstractMatcher.match()returns the first pattern that matches, in declaration order, so more specific patterns must come first. This corrects the sentence.The behaviour is pinned by a test in apache/struts#2004 (it fails when the matcher is changed to last-match-wins). The Convention-plugin ordering section further down the page is unaffected.
🤖 Generated with Claude Code