chore(DatabaseModal): simplify collapsible logic for extra extension section #36118
Conversation
Code Review Agent Run #fb7fcfActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/features/databases/DatabaseModal/ExtraOptions.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
msyavuz
left a comment
msyavuz
left a comment
There was a problem hiding this comment.
I think we can write some tests for this
EnxDev
force-pushed
the
enxdev/fix/dbt-cloud-panel
branch
from
35806af to
291424d
Compare
sadpandajoe
added
the
v6.0
sadpandajoe
removed
the
v6.0
4 participants
SUMMARY
This PR refactors the collapsible logic used when rendering the extra extension section in the modal. Previously the component always set the collapsible property, using 'icon' when the extension was enabled and 'disabled' when it was not.
The new approach removes the explicit 'icon' case and applies collapsible: 'disabled' only when the extension is not enabled. When the extension is enabled, the default behavior is used by omitting the collapsible field entirely.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION