Foresight based buffer implementation (with UMM integration) - not a feasible design #2341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add getNextAccessTime() for O(1) evict queries * add getBlocksInWindow() for prefetch lookup * cleanup() for memomry management with sliding window * ArrayList to LinkedList for O(1) removal * clear() method
* in the accesses list, remove the older access from currenttime
Contributor
|
Thanks @j143 for getting started on the OOC eviction logic. As a first step, I would recommend to implement a basic eviction mechanism for cached OOC streams (see resettable queue). We anyway need this baseline to compare the performance of any compiler-assisted optimization ("foresight-based") eviction and prefetching. Furthermore, you could use primitives from the LazyWriteBuffer but implement your own OOCEvictionManager (singleton) that all in-flight OOC streams can interact with. The UnifiedMemoryManager had a different purpose (reservations before running operations) such that I would not integrate the OOC logic there. |
Member
Author
|
Hi @mboehm7 - thanks for the design comments. that simplifies my design. let me create a design separately for OOC. |
j143
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fully work in progress implementation. Hoping to get it in a good shape in a couple of days.
look at review comment : #2341 (comment)