Skip to content

Conversation

@bobbai00
Copy link
Contributor

@bobbai00 bobbai00 commented Oct 19, 2025

What changes were proposed in this PR?

Add a new column in the user table called permission. This column stores what features user can use as a json string. This can open some sensitive features for only certain users controlled by the admin.

Here is the demo:
2025-10-20 14 19 34

Any related issues, documentation, discussions?

Close #3946

How was this PR tested?

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added feature engine ddl-change Changes to the TexeraDB DDL frontend Changes related to the frontend GUI common labels Oct 19, 2025
@chenlica chenlica requested review from aicam and kunwp1 October 20, 2025 03:09
@Yicong-Huang
Copy link
Contributor

@bobbai00 could you please use our PR template? Also, I think it's better to include some diagrams, it is hard for me to understand this change right now.

@bobbai00 bobbai00 force-pushed the feat/fine-grined-user-control branch from 90a61d7 to 59bf4ca Compare October 20, 2025 19:05
@bobbai00 bobbai00 changed the title feat: Add fine-grained user permission control system feat(admin): add per-user permission control by the system admins Oct 20, 2025
@Yicong-Huang
Copy link
Contributor

Yicong-Huang commented Nov 21, 2025

sorry I think I will have to -1 on this.

I am concerned about the naming permission as well as its design. I thought in another context, in the design of access control, we want have a permission relationship from user to resources. This implementation realizes permission, but seems to be another definition, it is more of a boolean value configuration, true/false to all computing units. This is not consistent with our design.

I suggest

  1. we add permission to specific resource (i.e., Computing Unit) management page (if we have one or building one), and for each resource, we should have a way for user to change permission to it.
  2. If we want to have a global flag for admin to configure if a particular user can ssh to computing units or not, create a column called configs BLOB in user table to store a json, and make this ssh-accessible as one of the json keys.

@chenlica
Copy link
Contributor

@bobbai00 Based on the experience of another permission-related topic, I think we don't need this feature any more, right?

@aicam and @kunwp1 You were assigned as reviewers. In general, please take care of such tasks timely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common ddl-change Changes to the TexeraDB DDL engine feature frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable per-user feature permission control for by admins

3 participants