Skip to content

Improve JdbcExecutor traversal by safely handling missing or multiple consumers #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohit-devlogs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve JdbcExecutor traversal by safely handling missing or multiple consumers #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...rms/wayang-jdbc-template/src/main/java/org/apache/wayang/jdbc/execution/JdbcExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,14 +371,29 @@ private static ExecutionTask findJdbcExecutionOperatorTaskInStage(final Executio

final Channel outputChannel = task.getOutputChannel(0);

if (outputChannel.getConsumers().size() != 1) {
final Collection<ExecutionTask> consumers = outputChannel.getConsumers();

// No consumer → end of pipeline
if (consumers.isEmpty()) {
return null;
}

final ExecutionTask consumer = outputChannel.getConsumers().iterator().next();
// Multiple consumers are currently unsupported
if (consumers.size() != 1) {
throw new WayangException(
String.format("Expected a single consumer for task %s but found %d.",
task,
consumers.size()
)
);
}

final ExecutionTask consumer = consumers.iterator().next();

return consumer.getStage() == stage && consumer.getOperator() instanceof JdbcExecutionOperator ? consumer
: null;
return consumer.getStage() == stage
&& consumer.getOperator() instanceof JdbcExecutionOperator
? consumer
: null;
}

private static SqlQueryChannel.Instance instantiateOutboundChannel(final ExecutionTask task,
Expand Down
Loading