Skip to content

WIP: [#7090] Ensure post-process resources are included in the jar, and en… #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: wicket-9.x
Choose a base branch
from
Open

WIP: [#7090] Ensure post-process resources are included in the jar, and en… #1279

wants to merge 1 commit into from

Conversation

@mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Oct 17, 2025 •
edited
Loading

…sure minify runs before bundle plugin

TODO:

  • Test deploying into OSGi runtime environment
  • Test using a decently complicated application

After this change, an unzip of wicket-core-9..-SNAPSHOT.jar has these resources:

% find . -name "*.js" -print
./org/apache/wicket/markup/html/form/CheckSelector.js
./org/apache/wicket/markup/html/form/CheckSelector.min.js
./org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.min.js
./org/apache/wicket/markup/html/form/upload/MultiFileUploadField.js
./org/apache/wicket/markup/html/form/upload/resource/FileUploadToResourceField.min.js
./org/apache/wicket/markup/html/form/upload/resource/FileUploadToResourceField.js
./org/apache/wicket/markup/html/form/upload/MultiFileUploadField.min.js
./org/apache/wicket/markup/html/form/upload/FilesSelectedBehavior.js
./org/apache/wicket/markup/html/pages/wicket-browser-info.min.js
./org/apache/wicket/markup/html/pages/wicket-browser-info.js
./org/apache/wicket/resource/jquery/jquery-1.12.4.min.js
./org/apache/wicket/resource/jquery/jquery-2.2.4.min.js
./org/apache/wicket/resource/jquery/jquery-1.12.4.js
./org/apache/wicket/resource/jquery/jquery-3.7.1.js
./org/apache/wicket/resource/jquery/jquery-2.2.4.js
./org/apache/wicket/resource/jquery/jquery-3.7.1.min.js
./org/apache/wicket/ajax/res/js/wicket-ajax-jquery.min.js
./org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

@mattrpav mattrpav self-assigned this Oct 17, 2025
@mattrpav mattrpav mentioned this pull request Oct 17, 2025
Closed
@mattrpav mattrpav changed the title [#7090] Ensure post-process resources are included in the jar, and en… WIP: [#7090] Ensure post-process resources are included in the jar, and en… Oct 17, 2025
@solomax
Copy link
Contributor

solomax commented Oct 18, 2025

I learn something new :))
I believe master also need to be updated accordingly :)
I'll try to check projects at wicketstuff-core in this regards :)

martin-g
martin-g reviewed Oct 18, 2025
View reviewed changes
pom.xml
<instructions>
<Export-Package>${osgi.export.package}</Export-Package>
<Import-Package>${osgi.import.package}</Import-Package>
<Include-Resource>${project.build.outputDirectory}, {maven-resources}</Include-Resource>
Copy link
Member

@martin-g martin-g Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-g martin-g martin-g left review comments

Assignees

@mattrpav mattrpav

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattrpav @solomax @martin-g