Repository navigation
Conversation
…espaces On a chrooted handle, the C client added the chroot to the client path before it validated the path. The check then incorrectly considered the full path, so a path that did not start with "/" would be silently accepted. Also, sub_string removed the chroot from server paths by length only rather than at path component boundaries. prepend_chroot now returns NULL for a NULL, empty, or relative client path on a chrooted handle. The isValidPath check of the caller then returns ZBADARGUMENTS, as on a plain handle. sub_string removes the chroot path only on a path component boundary and returns other paths unchanged. Sync config reads now use zoo_awgetconfig with a completion to standardize handling on one path. New tests in Zookeeper_simpleSystem: testChrootPathValidation, testChrootGetConfig, and testChrootServerPathMapping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a chrooted handle, the C client added the chroot to the client path before it validated the path. The check then incorrectly considered the full path, so a path that did not start with "/" would be silently accepted. Also,
sub_stringremoved the chroot from server paths by length only rather than at path component boundaries.prepend_chrootnow returns NULL for a NULL, empty, or relative client path on a chrooted handle. TheisValidPathcheck of the caller then returnsZBADARGUMENTS, as on a plain handle.sub_stringremoves the chroot path only on a path component boundary and returns other paths unchanged. Sync config reads now usezoo_awgetconfigwith a completion to standardize handling on one path.New tests in
Zookeeper_simpleSystem:testChrootPathValidation,testChrootGetConfig, andtestChrootServerPathMapping.