Skip to content

Conversation

@YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Aug 15, 2024

merge the capability from #7939 into release-0.9.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 15, 2024
@YTGhost YTGhost force-pushed the feat-updateStrategy-to-release-0.9 branch from 5f891e7 to 323ae66 Compare August 15, 2024 12:44
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Aug 15, 2024
@YTGhost YTGhost force-pushed the feat-updateStrategy-to-release-0.9 branch from 323ae66 to 8ce747b Compare August 16, 2024 02:37
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Aug 16, 2024
@codecov
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 42.42424% with 19 lines in your changes missing coverage. Please review.

Project coverage is 61.76%. Comparing base (bb4fbb1) to head (8ce747b).
Report is 1 commits behind head on release-0.9.

Files Patch % Lines
pkg/controller/component/rsm_convertor.go 0.00% 11 Missing ⚠️
pkg/controller/builder/builder_component.go 0.00% 3 Missing ⚠️
pkg/controller/instanceset/reconciler_update.go 40.00% 2 Missing and 1 partial ⚠️
...ntrollers/apps/configuration/reconfigure_policy.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #7978      +/-   ##
===============================================
- Coverage        65.24%   61.76%   -3.49%     
===============================================
  Files              356      448      +92     
  Lines            44676    53712    +9036     
===============================================
+ Hits             29150    33173    +4023     
- Misses           12946    17761    +4815     
- Partials          2580     2778     +198     
Flag Coverage Δ
unittests 61.76% <42.42%> (-3.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YTGhost YTGhost requested review from Y-Rookie and free6om August 16, 2024 02:48
@free6om free6om merged commit a5ad247 into apecloud:release-0.9 Aug 16, 2024
@github-actions github-actions bot added this to the Release 0.9.2 milestone Aug 16, 2024
@YTGhost YTGhost mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-approve Fork PR Pre Approve Test size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants