-
Notifications
You must be signed in to change notification settings - Fork 240
fix: don't ignore not found error in its controller #9823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto Cherry-pick Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9823 +/- ##
==========================================
- Coverage 50.86% 50.74% -0.13%
==========================================
Files 542 542
Lines 58771 58770 -1
==========================================
- Hits 29895 29823 -72
- Misses 25927 25997 +70
- Partials 2949 2950 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leon-inf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors from status calls should also be wrapped to maintain consistency.
|
The review comments above are addressed. @leon-inf PTAL |
When kb enables IN_PLACE_POD_VERTICAL_SCALING feature gate, but k8s does not, a vscale operation may fail in its because kube-apiserver does not have the "resize" subresource. ITS controller should error emit a warning event like:
But instead, its controller silently ignores this error and makes the reconcilation successful.