Skip to content

Conversation

@cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Oct 21, 2025

When kb enables IN_PLACE_POD_VERTICAL_SCALING feature gate, but k8s does not, a vscale operation may fail in its because kube-apiserver does not have the "resize" subresource. ITS controller should error emit a warning event like:

Warning  FailedReconcile              15m (x12 over 15m)  instance-set-controller  reconcile failed: the server could not find the requested resource

But instead, its controller silently ignores this error and makes the reconcilation successful.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 21, 2025
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.74%. Comparing base (0b9a9e2) to head (7cc2685).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/kubebuilderx/plan_builder.go 0.00% 8 Missing and 3 partials ⚠️
pkg/controller/kubebuilderx/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9823      +/-   ##
==========================================
- Coverage   50.86%   50.74%   -0.13%     
==========================================
  Files         542      542              
  Lines       58771    58770       -1     
==========================================
- Hits        29895    29823      -72     
- Misses      25927    25997      +70     
- Partials     2949     2950       +1     
Flag Coverage Δ
unittests 50.74% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Oct 21, 2025
@cjc7373 cjc7373 marked this pull request as ready for review October 22, 2025 02:58
@cjc7373 cjc7373 requested a review from a team as a code owner October 22, 2025 02:58
@cjc7373 cjc7373 added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Oct 22, 2025
Copy link
Contributor

@leon-inf leon-inf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors from status calls should also be wrapped to maintain consistency.

@cjc7373
Copy link
Contributor Author

cjc7373 commented Nov 20, 2025

The review comments above are addressed. @leon-inf PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants