feat: include every device slot in workspace cleanup - #767
Merged
janicduplessis merged 2 commits intoSep 13, 2026
Merged
Conversation
janicduplessis
added this pull request to stack #768
September 12, 2026 13:14
This was referenced Sep 12, 2026
janicduplessis
force-pushed
the
feat/device-slot-lifecycle
branch
from
September 12, 2026 16:55
902dec0 to
7eac923
Compare
janicduplessis
marked this pull request as ready for review
September 13, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Devices in named slots must stay claimed during GC and participate in workspace stop/removal. Reading only the default assignment would leave devices running or mistake them for orphans.
Depends on #764. Fixes #763.
Solution
Enumerate every slot for cleanup, ownership references, simulator-name reservations, and device capacity. Stop retains its default outcomes and reports named outcomes by platform and slot; a named-device failure fails the overall stop while allowing sibling cleanup.
Pool transfers operate on the selected slot under the config lock. Parking verifies its current device identity, and adoption refuses an occupied slot. Failed teardown keeps the project claim for a later cleanup attempt. Public launch selection follows in another layer of the stack.
Test plan
Regression tests cover slot-aware GC, cleanup continuing after failures, safe pool transfers, and device capacity. Native tool arguments are unchanged.