fix: capture process identity in macOS sandboxes - #3
Merged
Conversation
Contributor
Author
|
Fresh independent safety review completed for 0398667: no actionable code findings. Real sandbox and ordinary identity tests passed; clarified the description to distinguish a proven timestamp mismatch from an unverifiable saved boot ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
macOS process capture fails in the Codex workspace sandbox: reading the PID and exact start time succeeds, but the boot-session query returns
EPERM. Fixes #2.Solution
Allow new macOS tokens to omit boot identity when access is denied, retaining the exact microsecond start timestamp. Tokens already carrying a boot ID still require it to match. If the start timestamp matches, inability to verify the saved boot ID returns
ACCESS_DENIED.Without boot identity, a repeated PID and exact timestamp after a reboot or clock reset cannot be distinguished. This relaxes the original boot-ID requirement to allow restricted captures; the limitation is documented. Linux and Windows identity requirements are unchanged. Prepares
0.1.1.Test plan
npm run build && npm run test:sandboxexercises denied boot queries, both sandbox-boundary directions, denied process inspection, and deniedpsexecution.