feat: expose customActions on the element #1095
Conversation
|
The PR looks ok Please also add some integration tests to cover the new functionality for page source generation and element attributes fetching. Also, do not forget to update the element double declaration in unit tests |
ihor-kravchenko-evinced
force-pushed
the
feat/add-cutom-custom-actions-attribute
branch
from
400c791 to
6fbf62e
Compare
ihor-kravchenko-evinced
changed the title
ihor-kravchenko-evinced
force-pushed
the
feat/add-cutom-custom-actions-attribute
branch
from
ded5241 to
ab036df
Compare
Add support for exposing custom accessibility actions from UI elements.
ihor-kravchenko-evinced
force-pushed
the
feat/add-cutom-custom-actions-attribute
branch
from
ab036df to
f9518ed
Compare
@mykola-mokhnach thank you for the feedback. I've added tests for page source generation and element attributes fetching. |
KazuCocoa
left a comment
KazuCocoa
left a comment
There was a problem hiding this comment.
The code lgtm entirely. lets wait for the CI result
| FBSetCustomParameterForElementSnapshot(FBSnapshotMaxDepthKey, @50); | ||
| FBUseClearTextShortcut = YES; | ||
| FBLimitXpathContextScope = YES; | ||
| FBCustomActionsDelimiter = @", "; |
There was a problem hiding this comment.
I also think it makes sense to eliminate the extra space after comma
| * | ||
| * @param delimiter The delimiter string to use when joining custom actions | ||
| */ | ||
| + (void)setCustomActionsDelimiter:(NSString *)delimiter; |
There was a problem hiding this comment.
not sure if it makes sense to have this delimiter configurable. , should be enough
| XCTAssertEqualObjects(element.wdValue, @"1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901"); | ||
| } | ||
|
|
||
| - (void)testCustomActionsAttributes |
|
|
||
| + (void)setCustomActionsDelimiter:(NSString *)delimiter | ||
| { | ||
| FBCustomActionsDelimiter = delimiter ?: @", "; |
There was a problem hiding this comment.
@mykola-mokhnach Removed custom delimiter configuration 49f1d0d.
| } | ||
|
|
||
| // Case 2: Array of custom actions | ||
| if ([raw isKindOfClass:[NSArray class]]) { |
There was a problem hiding this comment.
I think it would be more readable if this method is split into smaller ones for each case
There was a problem hiding this comment.
also fine to do that in another PR, just let me know what works best for you @ihor-kravchenko-evinced
3 participants
Summary
This PR introduces support for exposing accessibility custom actions as an element attribute using private XCTest APIs.
Motivation
Once this is in place:
Implementation Notes
_XC_kAXXCAttributeCustomActionsThese changes are additive, so they do not change existing behaviour.