Add ODoH cryptographic routine implementation #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Sep 11, 2025
| let nonceSize = self.ct.aead.nonceByteCount | ||
| let keySize = self.ct.aead.keyByteCount | ||
| let responseNonceSize = max(nonceSize, keySize) | ||
| let responseNonce = Data((0..<responseNonceSize).map { _ in UInt8.random(in: 0...255) }) |
Contributor
There was a problem hiding this comment.
This is a fairly slow way to generate random numbers: we should at least be generating them 64-bytes at a time.
Contributor
Author
There was a problem hiding this comment.
We are only generating 16 bytes at the moment. Did you mean generate random numbers using UInt64s?
Contributor
There was a problem hiding this comment.
Sorry, yes, 64-bits at a time.
Contributor
Author
There was a problem hiding this comment.
Should be ready.
Lukasa
reviewed
Sep 12, 2025
| // Generate 8 bytes at a time | ||
| for _ in 0..<fullChunks { | ||
| let chunk = UInt64.random(in: UInt64.min...UInt64.max) | ||
| data.append(contentsOf: Swift.withUnsafeBytes(of: chunk) { Data($0) }) |
Contributor
There was a problem hiding this comment.
We don't need to create the intermediate Data if we flip the order:
Swift.withUnsafeBytes(of: chunk) {
data.append(contentsOf: $0) )
}
Lukasa
reviewed
Sep 12, 2025
| } | ||
|
|
||
| let finalChunk = UInt64.random(in: UInt64.min...UInt64.max) | ||
| let finalData = Swift.withUnsafeBytes(of: finalChunk) { Data($0) } |
Contributor
There was a problem hiding this comment.
Similar note here, we can apply prefix to the UnsafeRawBufferPointer and avoid the need to create a new temporary Data.
Lukasa
reviewed
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This change implements the core cryptographic routine for Oblivious DNS over HTTPS (ODoH) as specified in RFC 9230.
Modifications:
ODoH.Routinestruct with client-side and server-side cryptographic operationsResult:
The library now provides RFC9230 compliant ODoH cryptographic functionality.