Drop Swift 5.10 #46
Merged
Drop Swift 5.10 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious-http into drop_5_10
Contributor
|
We're going to need the CI changes and rules changes (cc @rnro) |
Lukasa
reviewed
Sep 25, 2025
| internal struct RoutineCore: Sendable { | ||
| internal let ct: HPKE.Ciphersuite | ||
| internal let pkR: any HPKEDiffieHellmanPublicKey | ||
| internal let keyID: Data |
Contributor
There was a problem hiding this comment.
I don't think these need to become let.
Contributor
Author
There was a problem hiding this comment.
I changed them back.
Lukasa
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift 5.10 is no longer supported, we should bump the swift-tools version.
Modifications:
Result:
Code reflects our support window.