vmss linux ssh for local admin enabled #1820
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphadev4
reviewed
Dec 28, 2023
plugins/azure/virtualmachinescaleset/scaleSetLinuxSSHEnabled.js
Outdated
Show resolved
Hide resolved
alphadev4
reviewed
Dec 28, 2023
alphadev4
requested changes
Jan 1, 2024
| domain: 'Compute', | ||
| description: 'Ensures that Azure Virtual Machine scale sets with Linux OS has SSH enabled.', | ||
| more_info: 'SSH is an encrypted connection protocol that allows secure sign-ins over unsecured connections. SSH is the default connection protocol for Linux VMs hosted in Azure.', | ||
| link: 'https://learn.microsoft.com/en-us/azure/virtual-machines/linux/ssh-from-windows', |
Collaborator
There was a problem hiding this comment.
is this correct? i think it should be this https://learn.microsoft.com/en-us/azure/virtual-machines/linux/mac-create-ssh-keys
| category: 'Virtual Machine Scale Set', | ||
| domain: 'Compute', | ||
| description: 'Ensures that Azure Virtual Machine scale sets with Linux OS has SSH enabled.', | ||
| more_info: 'SSH is an encrypted connection protocol that allows secure sign-ins over unsecured connections. SSH is the default connection protocol for Linux VMs hosted in Azure.', |
Collaborator
There was a problem hiding this comment.
write an advantage of using SSH key.
| var source = {}; | ||
| var locations = helpers.locations(settings.govcloud); | ||
|
|
||
| async.each(locations.vmScaleSet, function(location, rcb) { |
Collaborator
There was a problem hiding this comment.
We have two resources in locations.js vmScaleSet and virtualMachineScaleSets, can you use virtualMachineScaleSets instead making it consistent, and also remove the other from locations file along with its usage
Comment on lines
+36
to
+39
| if ((scaleSet.virtualMachineProfile.storageProfile && scaleSet.virtualMachineProfile.storageProfile.osDisk && | ||
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType && | ||
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType.toLowerCase() === 'linux')){ | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| if ((scaleSet.virtualMachineProfile.storageProfile && scaleSet.virtualMachineProfile.storageProfile.osDisk && | |
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType && | |
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType.toLowerCase() === 'linux')){ | |
| if (scaleSet.virtualMachineProfile && | |
| scaleSet.virtualMachineProfile.storageProfile && | |
| scaleSet.virtualMachineProfile.storageProfile.osDisk && | |
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType && | |
| scaleSet.virtualMachineProfile.storageProfile.osDisk.osType.toLowerCase() === 'linux'){ | |
| scaleSet.virtualMachineProfile.osProfile.linuxConfiguration.ssh){ | ||
| helpers.addResult(results, 0, 'VM scale set for linux has SSH enabled', location, scaleSet.id); | ||
| } else { | ||
| helpers.addResult(results, 2, 'VM scale set for linux does not have SSH enabled', location, scaleSet.id); |
Collaborator
There was a problem hiding this comment.
produce the message according to ssh keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.