This repository was archived by the owner on Feb 15, 2022. It is now read-only.
fix(db_infinite_loop): Address instance wherein the db connection is … #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…severed DBPgPP hangs indefintely
Procedure to reproduce
Fix
I use nc to create a listening socket and use DBD::PgPP to connect to that port during which I cancel the connection with ctrl-c and disconnect from nc (netcat). The tester script hangs and does not exit.
With the patch I am proposing it we get a stack trace when a disconnection occurs and it exits gracefully.
[tsaintvil]$ perl tester.pl
heyhey$VAR1 = sub { "DUMMY" };
DBI connect('dbname=test;host=127.0.0.1;port=543213','',...) failed: Connection to database disconnected
at /lib/perl5/DBD/PgPP.pm line 1045.
at /Redacted.pm line 436.
[tsaintvil@]$ nc -l 543213
(testtsaintvil^C
[tsaintvil@]$
I am open to comments, concerns, and suggestions. (perhaps retry?)