Repository navigation
Yul Parser: reject functions in nested loops inside for-init - #17219
Open
kutluhaneth46 wants to merge 1 commit into
Open
kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
Keep an init-depth counter so the grammar ban on function definitions anywhere inside a for-loop init block still applies when a nested loop switches the current component to post or body. Fixes argotorg#17211.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17211.
The Yul grammar forbids function definitions anywhere inside a for-loop init block. The parser only checked
m_currentForLoopComponent == ForLoopPre, so a nestedforinside init could switch the component to post/body and acceptfunctionthere.This adds
m_forInitDepth, incremented while parsing an init block, and uses that for the function-definition check. Nested loops inside init keep the ban active. Top-level for post/body still allow functions.Local checks:
isoltestonyulSyntaxTests/function_defined_in_init*, plussolc --strict-assemblysmoke for the issue repro.Checklist
AI Disclosure
Assisted with drafting the patch and tests. I reviewed every change and verified locally with isoltest and solc.