Repository navigation
SSA CFG: assert that a spill mload saw a store on every path leading up to it - #17220
Merged
Merged
Conversation
clonker
commented
Nov 13, 2026
Member
- a spilled variable is reloaded from its memory slot wherever the layout asks for it, which is only correct if a store of the variable lies on every path from the function entry to the load
- this pr asserts that this is indeed the case
- this does not fix SSA CFG: Invalid spilling order when instructions have the same definition stac #17077 but turns the miscompilations into ICEs
blishko
approved these changes
Nov 13, 2026
blishko
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me, I just have one question.
| m_spillEmitter && m_spillEmitter->hasAddress(_op.slot), | ||
| fmt::format("Tried storing variable {} without a spill slot", _op.slot) | ||
| ); | ||
| m_stores.emplace(_op.slot, _block); |
Contributor
There was a problem hiding this comment.
Should we check that it was not in m_stores already?
Do we have an invariant that there is at most one store for each slot?
Member
Author
There was a problem hiding this comment.
I deliberately didn't assert anything in that regard because we may want to actually have more than one store in the future. Right now we spill right after the definition site but that is not always optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.