Conversation
Contributor
Author
|
Apologies for the long delay here. I have been very busy lately, but I plan to revisit this patch soon, update it against the latest Armada release, and revalidate it on-device before requesting another review. Thank you for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add to Steamhelper for desktop files, executables, AppImages, scripts, and Windows executables.Why
Armada users currently have to add desktop applications through Steam manually. This provides the SteamOS-style desktop integration as an independent feature that can be reviewed and tested separately from Nested Desktop.
Validation
bash -n system_files/usr/bin/steamos-add-to-steamgit diff --checkType=Serviceextensions, which the generic freedesktop desktop-file validator does not recognize.