fix: raise error when reference is configured for non-belongs_to relationship #712
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Mar 10, 2026
Merged
fix: raise error when reference is configured for non-belongs_to relationship #712zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
…tionship Previously, configuring a reference on a has_many or has_one relationship was silently ignored. Now an error is raised with a helpful message explaining that references can only be configured on belongs_to relationships, since that's where the foreign key exists.
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Contributor
Author
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #423
Summary
Previously, configuring a reference on a
has_manyorhas_onerelationship was silently ignored during migration generation. This was confusing because users expected either a migration to be generated or an error message.Now an error is raised with a helpful message:
Found reference configuration for relationship timeslots, but it is a has_many relationship. References can only be configured for belongs_to relationships, because the foreign key is defined on the table with the belongs_to relationship. To configure the behavior of this foreign key, add the reference configuration to the resource with the corresponding belongs_to relationship.
Test plan
has_manyreference