Repository navigation
Pin Netlify build settings and Next.js runtime in netlify.toml - #145
Merged
Merged
Conversation
✅ Deploy Preview for p-ickup ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The configuration can be bypassed if the dashboard base directory resets, and the Next.js plugin version is not pinned.
2 open issues
What changed in this PR
This pull request adds repository-managed Netlify settings for the Next.js frontend to reduce reliance on dashboard configuration.
Changes:
- Defines
pnpm run buildas the Netlify build command. - Sets
.nextas the publish directory. - Enables
@netlify/plugin-nextjs. - Leaves the base directory dependent on Netlify dashboard configuration and does not pin the plugin version.
| File | Description |
|---|---|
frontend/netlify.toml |
Adds Netlify build, publish, and Next.js plugin settings; unresolved issues remain around declarative base-directory configuration and exact plugin version pinning. |
Review effort: Lite
| @@ -0,0 +1,9 @@ | |||
| # Netlify reads this file from the base directory (frontend/), which is set in the Netlify UI. | |||
| publish = ".next" | ||
|
|
||
| [[plugins]] | ||
| package = "@netlify/plugin-nextjs" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relinking the repo in Netlify (after the move to aspc) reset the site's build settings and dropped the auto-installed Next.js runtime. The next production build shipped without the server function and every page returned 404 (fixed by republishing the previous deploy).
This declares the build command, publish directory and
@netlify/plugin-nextjsinfrontend/netlify.toml, so the deploy no longer depends on dashboard state.