Conversation
This is one of the more complex behaviors remaining in the bash launcher, so let's move it into the node bootstrap in preparation for adopting hermetic_launcher. bootstrap.cjs now cds into `JS_BINARY__CHDIR` before deleting that variable. Deleting it prevents child processes or worker threads from attempting to cd to that same directory a second time. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
acozzette
marked this pull request as ready for review
August 28, 2026 04:28
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7872f7ae71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jbedard
reviewed
Aug 28, 2026
jbedard
reviewed
Aug 28, 2026
jbedard
reviewed
Aug 28, 2026
jbedard
approved these changes
Aug 28, 2026
jbedard
reviewed
Aug 28, 2026
jbedard
reviewed
Aug 28, 2026
acozzette
added a commit
that referenced
this pull request
Sep 3, 2026
The JS launcher was ported from a branch based on #2984, so the bash launcher changes that landed after it were missing: - #2995 dropped the `JS_BINARY__BINDIR` fallback in `resolve_execroot_bin_path`. `BAZEL_BINDIR` is already required by then, so the fallback only masked a misconfiguration. - #2991 made `NODE_DISABLE_COMPILE_CACHE=1` unconditional, leaving `bootstrap.cjs` to re-enable the cache when `NODE_COMPILE_CACHE` is set. The two forms agree on every combination the tests cover, but the conditional is the behavior #2991 deliberately replaced. The other two changes in that window were already reflected: #2994 moved chdir into `bootstrap.cjs` and #2984 moved coverage report generation into a node exit listener, and the JS launcher does neither. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the more complex behaviors remaining in the bash launcher, so let's move it into the node bootstrap in preparation for adopting hermetic_launcher.
bootstrap.cjs now cds into
JS_BINARY__CHDIRbefore deleting that variable. Deleting it prevents child processes or worker threads from attempting to cd to that same directory a second time.This necessitated updating
js_run_devserverto pass the normalized chdir value via the devserver's JSON config instead of throughJS_BINARY__CHDIR.Changes are visible to end-users: no
Test plan