fix: resolve chdir inside the tree the launcher leaves us in - #2995
Merged
Conversation
Currently we have an inconsistency in the way `js_binary(chdir)` is handled. If the `js_binary` target that sets `chdir` is in the main module, then we just cd directly from there into a subdirectory. However, if it is in a foreign module, then we cd to an absolute path within the bin directory. In the case of `bazel run` or a `js_test` that means we cd out of the runfiles tree in that situation. This change fixes the problem by making sure we stay within the current directory regardless of whether the `chdir` came from a foreign module or the main module. I also cleaned up the launcher script slightly by removing the behavior of falling back on `JS_BINARY__BINDIR` when `BAZEL_BINDIR` is unset. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
acozzette
marked this pull request as ready for review
August 29, 2026 15:49
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad26bd7f4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jbedard
reviewed
Aug 29, 2026
jbedard
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have an inconsistency in the way
js_binary(chdir)is handled. If thejs_binarytarget that setschdiris in the main module, then we just cd directly from there into a subdirectory. However, if it is in a foreign module, then we cd to an absolute path within the bin directory. In the case ofbazel runor ajs_testthat means we cd out of the runfiles tree in that situation.This change fixes the problem by making sure we stay within the current directory regardless of whether the
chdircame from a foreign module or the main module.I also cleaned up the launcher script slightly by removing the behavior of falling back on
JS_BINARY__BINDIRwhenBAZEL_BINDIRis unset.Changes are visible to end-users: yes
Always resolve chdir inside the tree the launcher leaves us in.
Test plan