This repository was archived by the owner on Dec 16, 2023. It is now read-only.
feat: allow custom file name generator function#162
Open
mweibel wants to merge 1 commit intoassaf:masterfrom
Open
feat: allow custom file name generator function#162mweibel wants to merge 1 commit intoassaf:masterfrom
mweibel wants to merge 1 commit intoassaf:masterfrom
Conversation
mweibel
force-pushed
the
custom-file-name
branch
from
96f2e09 to
21fab7b
Compare
capaj
reviewed
Sep 9, 2021
| ```javascript | ||
| Replay.filenameGenerator = function(request) { | ||
| // just an example, you may want to improve that | ||
| return `${slugify(`${request.method.toUpperCase()}_${request.url.path}`)}_${Date.now()}${Math.floor(Math.random() * 100000)}`; |
There was a problem hiding this comment.
IMHO this should be the default, not the one with just the date time stamp
capaj
approved these changes
Sep 9, 2021
capaj
left a comment
capaj
left a comment
There was a problem hiding this comment.
LGTM, I'd just prefer the filename generator to use the path by default as shown in the example
Author
|
@capaj thanks for replying. However meanwhile (almost 3 years ago I opened this PR ;)) I'm not using node-replay anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #59