Skip to content

OUT-3527: allow single quotes in names when querying QBO#214

Merged
SandipBajracharya merged 1 commit intomasterfrom
OUT-3527-re
Apr 8, 2026
Merged

OUT-3527: allow single quotes in names when querying QBO#214
SandipBajracharya merged 1 commit intomasterfrom
OUT-3527-re

Conversation

@SandipBajracharya
Copy link
Copy Markdown
Collaborator

Summary

  • Preserve apostrophes (') in customer, item, and account names instead of replacing them with hyphens via replaceSpecialCharsForQB
  • Add escapeForQBQuery() helper to escape single quotes as \' in QBO query strings
  • Apply escaping in _getACustomer, _getCustomerByEmail, _getAnItem, _getInvoice, and _getAnAccount to prevent query syntax errors

Test plan

  • Create an invoice for a customer with an apostrophe in their name (e.g., "John's Cafe") and verify it syncs correctly without creating a duplicate
  • Verify existing mapped customers/items (without apostrophes) continue to sync normally
  • Verify existing mapped customers/items with names that previously had ' replaced by - still resolve by QBO ID

🤖 Generated with Claude Code

Preserve apostrophes in customer, item, and account names instead of
replacing them with hyphens, and escape them in QBO query strings to
prevent syntax errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear
Copy link
Copy Markdown

linear bot commented Apr 7, 2026

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
quickbooks-sync Building Building Apr 7, 2026 10:43am
quickbooks-sync (dev) Ready Ready Preview, Comment Apr 7, 2026 10:43am

Request Review

@SandipBajracharya SandipBajracharya changed the title fix(OUT-3527): allow single quotes in names when querying QBO OUT-3527: allow single quotes in names when querying QBO Apr 7, 2026
Copy link
Copy Markdown
Collaborator

@priosshrsth priosshrsth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@SandipBajracharya SandipBajracharya merged commit bf3eb7b into master Apr 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants