OUT-2939 | Support comments' attachments deletion from supabase bucket.#1109
Open
arpandhakal wants to merge 6 commits intofeature/template-dynamic-fieldsfrom
Open
OUT-2939 | Support comments' attachments deletion from supabase bucket.#1109arpandhakal wants to merge 6 commits intofeature/template-dynamic-fieldsfrom
arpandhakal wants to merge 6 commits intofeature/template-dynamic-fieldsfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
force-pushed
the
feature/api-improvements
branch
from
a7df534 to
cdd4a58
Compare
arpandhakal
requested review from
SandipBajracharya and
rrojan
and removed request for
rrojan
…ks and comments that arent deleted
…ttachmentRequests in db
…ttachmentRequests in db
…upabase buckets in scrap medias. cleaned out some services
…upabase buckets in scrap medias. cleaned out some services
…xed the issue of stale url going to scrapMedias table for only comments and replies
Contributor
|
Deployment failed with the following error: Learn More: https://vercel.link/multiple-function-regions |
arpandhakal
changed the base branch from
main
to
feature/template-dynamic-fields
| } | ||
| } | ||
|
|
||
| if (!!scrapMediasToDeleteFromBucket.length) |
Collaborator
There was a problem hiding this comment.
I think a curly braces block is missing for this if condition. Maybe it should have scope till line 99? Can you please verify this? @arpandhakal
SandipBajracharya
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria