Skip to content

OUT-2998 | Bad comment/task ID returns 400 instead of 404#1117

Open
arpandhakal wants to merge 2 commits intofeature/template-dynamic-fieldsfrom
OUT-2998
Open

OUT-2998 | Bad comment/task ID returns 400 instead of 404#1117
arpandhakal wants to merge 2 commits intofeature/template-dynamic-fieldsfrom
OUT-2998

Conversation

@arpandhakal
Copy link
Copy Markdown
Collaborator

Changes

  • added a validation to check valid uuids for in public controllers. If the uuid is invalid.
  • applied short circuit to throw 404 error

Testing Criteria

image image

@arpandhakal arpandhakal requested a review from rrojan February 2, 2026 08:05
@arpandhakal arpandhakal self-assigned this Feb 2, 2026
@linear
Copy link
Copy Markdown

linear bot commented Feb 2, 2026

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tasks-app Ready Ready Preview, Comment Mar 31, 2026 9:09am

Request Review

…controllers. If the uuid is invalid, applied short circuit to throw 404 error
…controllers. If the uuid is invalid, applied short circuit to throw 404 error
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

Deployment failed with the following error:

Deploying Serverless Functions to multiple regions is restricted to the Pro and Enterprise plans.

Learn More: https://vercel.link/multiple-function-regions

@arpandhakal arpandhakal changed the base branch from main to feature/template-dynamic-fields March 31, 2026 09:06
Copy link
Copy Markdown
Collaborator

@SandipBajracharya SandipBajracharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants