Skip to content

fix: bring dependency resolution back#29

Merged
rikosellic merged 3 commits into
asterinas:mainfrom
Marsman1996:fix-doc
Jul 2, 2026
Merged

fix: bring dependency resolution back#29
rikosellic merged 3 commits into
asterinas:mainfrom
Marsman1996:fix-doc

Conversation

@Marsman1996

@Marsman1996 Marsman1996 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Have to bring dependency logic back...

@Marsman1996

Copy link
Copy Markdown
Collaborator Author

Shall we rename compile to build to align with cargo verus?

@Marsman1996 Marsman1996 requested a review from rikosellic July 2, 2026 12:04
@rikosellic

Copy link
Copy Markdown
Collaborator

Shall we rename compile to build to align with cargo verus?

Good idea!

@rikosellic

Copy link
Copy Markdown
Collaborator

Is this caused by doc?

@Marsman1996

Copy link
Copy Markdown
Collaborator Author

Is this caused by doc?

Yes, to compile the doc it requires the compiled dependency files.
This makes me wonder how the original dv works...

@rikosellic

Copy link
Copy Markdown
Collaborator

Alright, at least we do simplify some code. Thanks for your contribution!

@rikosellic rikosellic merged commit d2061d2 into asterinas:main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants