Skip to content

Prove page table child permission axiom - #614

Merged
rikosellic merged 3 commits into
asterinas:mainfrom
Je5s1e:prove/page_table_child_permission_axiom
Jul 12, 2026
Merged

Prove page table child permission axiom#614
rikosellic merged 3 commits into
asterinas:mainfrom
Je5s1e:prove/page_table_child_permission_axiom

Conversation

@Je5s1e

@Je5s1e Je5s1e commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Replace page-table child permission axioms with checked Verus proofs.

This proves the tracked constructors and cursor/page-table ownership transitions needed for child permission updates, removes the set_children_perm trusted helper, and adds supporting VA/page-size and metaregion preservation lemmas.

@rikosellic
rikosellic self-requested a review July 8, 2026 00:20

@rikosellic rikosellic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify the proofs first, it looks verbose.

Comment thread ostd/specs/mm/page_table/cursor/va_lemmas.rs Outdated
Comment thread ostd/specs/mm/page_table/cursor/va_lemmas.rs
Comment thread ostd/specs/mm/embedding/mod.rs Outdated
@Je5s1e
Je5s1e requested review from hiroki-chen and rikosellic July 10, 2026 08:27
Comment thread ostd/specs/mm/embedding/mod.rs Outdated
Comment thread ostd/specs/mm/embedding/mod.rs Outdated
Comment thread ostd/specs/mm/page_table/cursor/va_lemmas.rs Outdated
Comment thread ostd/specs/mm/page_table/mod.rs Outdated
Comment thread ostd/specs/mm/page_table/node/entry_owners.rs Outdated
Comment thread ostd/specs/mm/page_table/owners.rs Outdated
Comment thread ostd/src/mm/page_table/cursor/mod.rs Outdated
Comment thread ostd/src/mm/page_table/mod.rs Outdated
@rikosellic
rikosellic self-requested a review July 10, 2026 09:09

@rikosellic rikosellic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some styling issues and some redundant proofs.

@rikosellic

Copy link
Copy Markdown
Collaborator

@hiroki-chen I also think this PR suggests that some other Owners are also redundant. This may be done in a separate PR.

@Marsman1996
Marsman1996 force-pushed the prove/page_table_child_permission_axiom branch from 0f6d3af to ba9fe19 Compare July 10, 2026 14:46
Co-authored-by: Chao Jiang <85332676+Je5s1e@users.noreply.github.com>
@Marsman1996
Marsman1996 force-pushed the prove/page_table_child_permission_axiom branch from ba9fe19 to f3a4830 Compare July 11, 2026 03:42
@Marsman1996

Copy link
Copy Markdown
Collaborator

@Je5s1e Next time before the PR, you shall check the code first and run the post-processing skills

@Marsman1996
Marsman1996 requested a review from rikosellic July 11, 2026 03:48
Comment thread ostd/src/mm/page_table/mod.rs
Comment thread ostd/specs/mm/page_table/cursor/owners.rs
@Marsman1996
Marsman1996 force-pushed the prove/page_table_child_permission_axiom branch from f3a4830 to 8de969b Compare July 11, 2026 05:43
@rikosellic

Copy link
Copy Markdown
Collaborator

LGTM, please also wait the approval from @hiroki-chen.

@rikosellic
rikosellic self-requested a review July 12, 2026 02:42
@rikosellic

Copy link
Copy Markdown
Collaborator

Thanks for your contributions!

@rikosellic
rikosellic merged commit 9f303a1 into asterinas:main Jul 12, 2026
4 checks passed
@Marsman1996 Marsman1996 added the AI-assist AI-aided proof or generation label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-assist AI-aided proof or generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants